Fix Adami boundary viscosity#853
Merged
LasNikas merged 6 commits intotrixi-framework:mainfrom Jul 23, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
==========================================
+ Coverage 70.38% 70.46% +0.08%
==========================================
Files 106 106
Lines 6894 6894
==========================================
+ Hits 4852 4858 +6
+ Misses 2042 2036 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Can you add a test for compute_adami_density and compute_wall_velocity? |
Member
Author
|
Done. |
svchb
requested changes
Jul 22, 2025
svchb
approved these changes
Jul 22, 2025
Collaborator
|
/run-gpu-tests |
LasNikas
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
AdamiPressureExtrapolation, the velocity extrapolation was passingsystem_coordsinstead ofvtocurrent_velocity. This argument wasn't used for boundary systems, but for TLSPH, it did not work correctly.This is on main:
The boundary layer is clearly smaller at the blade of the fin on the right, which is the integrated TLSPH part. The left are fixed particles, so wall viscosity is working correctly.
This PR:
